Silence unused-command-line-argument warning, not just the error #1506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning is absolutely spammy. We also disable the warning in BinaryBuilder, it's so annoying: https://github.com/JuliaPackaging/BinaryBuilderBase.jl/blob/99594c5cae8f67b9cdc776418744d88e574d4e05/src/Runner.jl#L449.
This reverts commit 6077bac.
This partially reverts commit ec0c61f. Keep `cc` mandatory, only make `gcc_host_compiler_path` optional.
wsmoses
approved these changes
Jul 29, 2025
|
I don't really like making |
|
Failures are also on |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1506 +/- ##
===========================================
+ Coverage 21.66% 40.11% +18.44%
===========================================
Files 46 122 +76
Lines 8048 21699 +13651
===========================================
+ Hits 1744 8705 +6961
- Misses 6304 12994 +6690 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning is absolutely spammy. We also disable the warning in BinaryBuilder,
it's so annoying:
https://github.com/JuliaPackaging/BinaryBuilderBase.jl/blob/99594c5cae8f67b9cdc776418744d88e574d4e05/src/Runner.jl#L449.