Skip to content

Conversation

avik-pal
Copy link
Collaborator

No description provided.

@avik-pal avik-pal force-pushed the ap/generalize_scatter branch 2 times, most recently from 9c940ba to 9265c83 Compare June 11, 2025 23:29
@avik-pal avik-pal requested a review from wsmoses June 11, 2025 23:42
@avik-pal avik-pal force-pushed the ap/generalize_scatter branch from 9265c83 to d640a91 Compare June 11, 2025 23:56
Copy link
Member

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a test case offhand

@avik-pal
Copy link
Collaborator Author

the existing codepaths from setindex! should use this path now

@wsmoses
Copy link
Member

wsmoses commented Jun 12, 2025

Ah got it

@avik-pal avik-pal merged commit a645d94 into main Jun 12, 2025
50 of 56 checks passed
@avik-pal avik-pal deleted the ap/generalize_scatter branch June 12, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants