Skip to content

@trace: Promote loop variables to traced numbers #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 9, 2025
Merged

@trace: Promote loop variables to traced numbers #1381

merged 4 commits into from
Jun 9, 2025

Conversation

Pangoraw
Copy link
Collaborator

@Pangoraw Pangoraw commented Jun 9, 2025

No description provided.

Pangoraw
Pangoraw commented Jun 9, 2025
View reviewed changes
lib/ReactantCore/src/ReactantCore.jl Outdated
Comment on lines 297 to 299
$start_sym = Reactant.TracedUtils.promote_to(Reactant.TracedRNumber{Reactant.unwrapped_eltype(typeof($start_sym))}, $start_sym)
$limit_sym = Reactant.TracedUtils.promote_to(Reactant.TracedRNumber{Reactant.unwrapped_eltype(typeof($limit_sym))}, $limit_sym)
$step_sym = Reactant.TracedUtils.promote_to(Reactant.TracedRNumber{Reactant.unwrapped_eltype(typeof($step_sym))}, $step_sym)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not the best to use Reactant from ReactantCore here, so if anyone has a better idea, i'll take it

@Pangoraw Pangoraw linked an issue Jun 9, 2025 that may be closed by this pull request
for with track_numbers=false is broken #1380
Closed
@wsmoses
Copy link
Member

wsmoses commented Jun 9, 2025

The failures seem new?

@codecov Codecov
Copy link

codecov bot commented Jun 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.63%. Comparing base (b6ffc96) to head (4ccde71).
Report is 1177 commits behind head on main.

Files with missing lines Patch % Lines
lib/ReactantCore/src/ReactantCore.jl 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1381       +/-   ##
===========================================
+ Coverage   21.66%   43.63%   +21.96%     
===========================================
  Files          46      115       +69     
  Lines        8048    20745    +12697     
===========================================
+ Hits         1744     9052     +7308     
- Misses       6304    11693     +5389

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wsmoses wsmoses merged commit 01fdef6 into EnzymeAD:main Jun 9, 2025
56 of 57 checks passed
@wsmoses
Copy link
Member

wsmoses commented Jun 10, 2025

@Pangoraw minor but looking at the docs, can we change the else in the control flow to be x^3 or something, since otherwise Reactant compiles out the identity to not return anything and reuse the input instead of call with mlir: https://enzymead.github.io/Reactant.jl/dev/tutorials/control-flow

@Pangoraw Pangoraw deleted the trace-for-track-numbers branch June 16, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsmoses wsmoses wsmoses approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

for with track_numbers=false is broken
2 participants
@Pangoraw @wsmoses