Skip to content

fix #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

fix #605

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions crates/emmylua_ls/src/handlers/rename/rename_member.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,15 @@ pub fn rename_member_references(
.get_member_index()
.get_member(&member_id)?;
let key = member.get_key();
let index_references = semantic_model
.get_db()
.get_reference_index()
.get_index_references(&key)?;
let index_references: Vec<emmylua_code_analysis::InFiled<emmylua_parser::LuaSyntaxId>> =
semantic_model
.get_db()
.get_reference_index()
.get_index_references(&key)?;

let property_owner = find_member_origin_owner(compilation, semantic_model, member_id)
let origin_property_owner = find_member_origin_owner(compilation, semantic_model, member_id)
.unwrap_or(LuaSemanticDeclId::Member(member_id));
let property_owner = LuaSemanticDeclId::Member(member_id);
let mut semantic_cache = HashMap::new();
for in_filed_syntax_id in index_references {
let semantic_model =
Expand All @@ -43,6 +45,10 @@ pub fn rename_member_references(
let root = semantic_model.get_root();
let node = in_filed_syntax_id.value.to_node_from_root(root.syntax())?;
if semantic_model.is_reference_to(
node.clone(),
origin_property_owner.clone(),
SemanticDeclLevel::NoTrace,
) || semantic_model.is_reference_to(
node.clone(),
property_owner.clone(),
SemanticDeclLevel::NoTrace,
Expand All @@ -56,7 +62,6 @@ pub fn rename_member_references(
}
}
}

Some(())
}

Expand Down
20 changes: 20 additions & 0 deletions crates/emmylua_ls/src/handlers/test/rename_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -83,4 +83,24 @@ mod tests {
);
assert!(result);
}

#[test]
fn test_rename_class_field_1() {
let mut ws = ProviderVirtualWorkspace::new();
let result = ws.check_rename(
r#"
---@class ABC
local ABC = {}

local function test()
end
ABC.te<??>st = test

ABC.test()
"#,
"test1".to_string(),
2,
);
assert!(result);
}
}