update #381
Merged
update #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribru17
reviewed
Apr 21, 2025
| @@ -23,7 +23,7 @@ impl Default for EmmyrcStrict { | |||
| Self { | |||
| require_path: false, | |||
| type_call: false, | |||
| array_index: true, | |||
| array_index: false, | |||
There was a problem hiding this comment.
Because arrays in almost all languages do not return nullable values when accessing elements, whether the index is out of bounds should be handled by the user.
Moreover, we currently lack an effective way to suppress this warning individually. I think we can enable it by default after implementing the ---@as -? syntax.
严格模式不应该默认启用
default `true`. 为`true`时在`meta`文件内定义的签名会覆盖`file`内的真实签名
|
@CppCXY 啥时候合并? 这么多提交等下冲突不好解决 |
CppCXY
reviewed
Apr 25, 2025
| @@ -304,9 +316,10 @@ function debug.traceback(thread, message, level) end | |||
| --- access a same external local variable) will return identical ids for those | |||
| --- upvalue indices. | |||
| ---@version >5.2, JIT | |||
| ---@param f fun():integer | |||
| ---@param f async fun(...):any... | |||
| @@ -23,7 +23,7 @@ impl Default for EmmyrcStrict { | |||
| Self { | |||
| require_path: false, | |||
| type_call: false, | |||
| array_index: true, | |||
| array_index: false, | |||
| @@ -145,6 +147,13 @@ impl LuaTypeDecl { | |||
| } | |||
| } | |||
|
|
|||
| pub fn get_alias(&self) -> Option<&LuaType> { | |||
| @@ -109,7 +109,6 @@ pub fn get_default_severity(code: DiagnosticCode) -> DiagnosticSeverity { | |||
| DiagnosticCode::InjectFieldFail => DiagnosticSeverity::ERROR, | |||
| DiagnosticCode::UnreachableCode => DiagnosticSeverity::HINT, | |||
| DiagnosticCode::Unused => DiagnosticSeverity::HINT, | |||
| DiagnosticCode::UndefinedGlobal => DiagnosticSeverity::ERROR, | |||
CppCXY
reviewed
Apr 25, 2025
| } else { | ||
| let trace_info = UnResolveTraceInfo::Trace(trace_info); | ||
| self.unresolve_traces.insert(trace_id, trace_info); | ||
| self.unresolve_traces | ||
| .insert(trace_id, (self.current_flow_id.unwrap(), trace_info)); |
| if next_guard.is_err() { | ||
| return false; | ||
| } | ||
| check_general_type_compact(db, &source, field, next_guard.unwrap()) |
| if next_guard.is_err() { | ||
| return false; | ||
| } | ||
| check_general_type_compact(db, source, t, next_guard.unwrap()).is_ok() |
crates/emmylua_code_analysis/src/semantic/type_check/simple_type.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #382