Set MSRV to 1.70 and remove a few unused dependencies.#21
Merged
Jake-Shadle merged 1 commit intoEmbarkStudios:mainfrom Mar 6, 2026
Merged
Set MSRV to 1.70 and remove a few unused dependencies.#21Jake-Shadle merged 1 commit intoEmbarkStudios:mainfrom
Jake-Shadle merged 1 commit intoEmbarkStudios:mainfrom
Conversation
Contributor
Author
|
May I ask if there's something I can do to get this merged? If you are concerned about introducing an MSRV, then I can also remove that. The only thing that I'd really need is the Rust |
Member
|
Github won't allow me to push changes to your fork, please apply this diff and I'll merge. |
Contributor
Author
|
@Jake-Shadle, thank you so much for merging this, and for making the changes to CI (ff1a2a6)! And thanks also for maintaining toml-span --- it has been a breeze to use. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
This sets an MSRV of 1.70 and decreases the required edition to 2021, making it possible to compile toml-span with older compilers. This enables me in particular to use toml-span in my own project, where I have an MSRV of 1.70 as well.
Furthermore, this removes a few unused dependencies from the workspace, such as
synandquote.