linker/duplicates: handle all decorations instead of special-casing zombies. #949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to avoid deduplication in some cases (where it destroys useful information for debugging "what specific part of the source code caused this invalid type to be generated"), I came across the special-casing for zombies in
make_dedupe_key
(which avoids other unwanted cases of zombie deduplications).But
gather_annotations
should be processing all decorations including theOpDecorateString
used for the "custom decorations" system that includes zombies, it just looks like an accidental omission in the past.The other change here is to ignore some "type mismatches" that result from slightly-different zombies annotations showing up on otherwise-identical types from different crates (likely the first
Span
passed toSpirvType::def
gets cached, so the codegen order influences this).The reason they're safe to ignore is that "zombies" (i.e. deferred errors) have only two possible outcomes: