Skip to content

Add test for issue #329 #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2021
Merged

Add test for issue #329 #781

merged 1 commit into from
Oct 28, 2021

Conversation

khyperia
Copy link
Contributor

Strangely fixed already. Add test to make sure we don't regress.

Fixes #329

@khyperia khyperia enabled auto-merge (squash) October 28, 2021 07:54
@khyperia khyperia requested a review from eddyb October 28, 2021 08:34
eddyb
eddyb approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one might be the MIR pass that constant-folds .len() calls based on type?

@khyperia khyperia merged commit 6254813 into main Oct 28, 2021
@khyperia khyperia deleted the issue-329 branch October 28, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@eddyb eddyb eddyb approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't call .len() on an array
2 participants
@khyperia @eddyb