Introduce remove_unused_params
pass, to run just before zombie removal.
#715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing (transitively) dead
fn
parameters, this PR also removes their matching arguments, which could be invalid (i.e. zombies).The main usecase is
#[track_caller]
, which is becoming more prevalent incore
.The added test fails before this PR with:
This allows updating past rust-lang/rust#86664 (which gets transitively called from
mem::replace
).Also, I tried using this to remove our hardcoded panic hacks, but it's not compatible with
-C debuginfo=2
(even if the%x.dbg.spill
stack slots have no debuginfo attached, they're still created andstore
d to, so they get in the way).