Add support for outputting multiple modules, one per entry point #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
changed the title
|
thanks, my brain is mush right now :P |
VZout
approved these changes
Mar 29, 2021
XAMPPRocky
reviewed
Mar 29, 2021
| @@ -380,6 +380,9 @@ impl CodegenBackend for SpirvCodegenBackend { | |||
| ) -> Result<(), ErrorReported> { | |||
| // TODO: Can we merge this sym with the one in symbols.rs? | |||
| let legalize = !sess.target_features.contains(&Symbol::intern("kernel")); | |||
| let emit_multiple_modules = sess | |||
| .target_features | |||
| .contains(&Symbol::intern("multimodule")); | |||
There was a problem hiding this comment.
Would it be more appropriate if we accepted this as an argument from -Cllvm-args(sess.cg.llvm_args)? It's not really something that's specific to the the target as it is specific to our backend. Another benefit is since it is just Vec<String>, we could use clap here for getting these arguments, that's make it to have key value arguments like --module-output=[multiple|single].
XAMPPRocky
approved these changes
Mar 29, 2021
XAMPPRocky
pushed a commit
that referenced
this pull request
May 3, 2021
* Add multimodule feature * Use -Cllvm-args instead of -Ctarget-feature for multimodule * Fix cargo.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #539
Not sure if I should actually include the
examples/multibuildercrate, I'm fine with deleting it (also for some reason it only works when cd'ing into the dir and runningcargo run --release, it fails to find thecargoexe when running withcargo run --release -p multibuilder)