Skip to content

Update vite_preload_tag to emit one early hint per entrypoint #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ElMassimo merged 4 commits into from
Sep 22, 2023
Merged

Update vite_preload_tag to emit one early hint per entrypoint #402

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de4f9db
Update vite_preload_tag to emit one early hint per entrypoint
PikachuEXE Sep 21, 2023
ee48d02
Update vite_rails/lib/vite_rails/tag_helpers.rb
PikachuEXE Sep 22, 2023
c5f12c1
Fix rubocop violations
PikachuEXE Sep 22, 2023
e32d86f
chore: fix escape sequence of newline
ElMassimo Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions vite_rails/lib/vite_rails/tag_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,15 @@ def vite_manifest

# Internal: Renders a modulepreload link tag.
def vite_preload_tag(*sources, crossorigin:, **options)
sources.map { |source|
href = path_to_asset(source)
try(:request).try(:send_early_hints, 'Link' => %(<#{ href }>; rel=modulepreload; as=script; crossorigin=#{ crossorigin }))
asset_paths = sources.map { | source | path_to_asset(source) }
Comment thread
PikachuEXE marked this conversation as resolved.
Outdated
try(:request).try(
:send_early_hints,
'Link' => asset_paths.map do |href|
%(<#{ href }>; rel=modulepreload; as=script; crossorigin=#{ crossorigin })
end.join("\n"),
)
asset_paths.map do |href|
tag.link(rel: 'modulepreload', href: href, as: 'script', crossorigin: crossorigin, **options)
}.join("\n").html_safe
end.join("\n").html_safe
Comment thread
PikachuEXE marked this conversation as resolved.
Outdated
end
end