Skip to content

Get home page using updated endpoint (Fixes #324) #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

Nokse22
Copy link
Contributor

@Nokse22 Nokse22 commented Aug 2, 2025

This is just an hack, now only playlist works. Help is very much appreciated

@Nokse22
Copy link
Contributor Author

Nokse22 commented Aug 2, 2025

Now just mixes don't work

@tehkillerbee tehkillerbee changed the title Try to fix #324 Get home page using updated endpoint (Fixes #324) Aug 2, 2025
@tehkillerbee
Copy link
Collaborator

tehkillerbee commented Aug 2, 2025

Thanks for your additions. I've made a new branch here to continue working on it. I've made some adjustments and will see if i can get mixes working as well.

https://github.com/EbbLabs/python-tidal/tree/fix/issue-324

@tehkillerbee
Copy link
Collaborator

Now just mixes don't work

Hmm. Mixes (Both v1 and v2) seem to work fine in my end (albeit slow to parse). What error do you get?

@Nokse22
Copy link
Contributor Author

Nokse22 commented Aug 2, 2025

The mixes on the home fail to parse, that's why I have commented these lines. The json is completely different

Here is the same mix from the Home Page and from Mixes & Radios

Home Page Mixes & Radios
Screenshot From 2025-08-02 20-32-40 Screenshot From 2025-08-02 20-33-24

@tehkillerbee
Copy link
Collaborator

Ah sorry, I see what went wrong before when I tested. It looks like I simply used the Mix id and parsed it directly. Of course that will work fine, but that is not the intended way (we should use the json obj instead to populate the object). And as you point out, the fields seem to be quite a bit different but it should be relatively straightforward to fix them.

But it seems odd if the json object is changed only in this case. Perhaps the json object has been changed, thus parsing broken for some time?

@Nokse22
Copy link
Contributor Author

Nokse22 commented Aug 2, 2025

The rest of the mixes still return the old json and are parsed correctly, I don't know why it is this way. I also tried using the id, but it become very slow.

@tehkillerbee
Copy link
Collaborator

Take a look:
#353

This seems to work as expected but could do with a bit of cleanup (I am not a fan of having both V1 and V2 parsers/endpoints). For Mixes, they could probably be removed altogether, as I am not sure why we prefer to keep the V1 endpoint in the first place.

For Pages, I have not checked what endpoint is used when browsing other pages.

@Nokse22 Nokse22 closed this Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants