Add Huawei_V100R023C10 PowerSupply driver #1336
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-ctc
requested review from
Pietfried,
hikinggrass,
corneliusclaussen,
SebaLukas,
andistorm and
mlitre
as code owners
hikinggrass
changed the title
hikinggrass
requested changes
Aug 28, 2025
modules/HardwareDrivers/PowerSupplies/Huawei_V100R023C10/fusion_charger_lib/.clang-format
Outdated
Show resolved
Hide resolved
james-ctc
force-pushed
the
feature/added-huawei-v100r023c10
branch
2 times, most recently
from
d418a87 to
37ead93
Compare
* Add Huawei power stack driver Co-authored-by: Fabian Gajek <[email protected]> Co-authored-by: Mark Oude Elberink <[email protected]> Huawei V100R023C10 Updates (#137) Huawei V100R023C10: multiple connector support Co-authored-by: Tim <[email protected]> import Huawei_V100R023C10 power supply from BaseCamp Signed-off-by: James Chapman <[email protected]> fix: removed clang format files Signed-off-by: James Chapman <[email protected]>
james-ctc
force-pushed
the
feature/added-huawei-v100r023c10
branch
from
37ead93 to
713c140
Compare
hikinggrass
reviewed
Aug 29, 2025
hikinggrass
requested changes
Aug 29, 2025
| @@ -0,0 +1,45 @@ | |||
| cmake_minimum_required(VERSION 3.22) | |||
There was a problem hiding this comment.
To keep this in line with everest-core itself
Suggested change
| cmake_minimum_required(VERSION 3.22) | |
| cmake_minimum_required(VERSION 3.16) |
| cmake_minimum_required(VERSION 3.22) | ||
| project(fusion-charge-dispenser) | ||
|
|
||
| set(CMAKE_CXX_STANDARD 20) |
There was a problem hiding this comment.
everest-core targets C++17
Suggested change
| set(CMAKE_CXX_STANDARD 20) | |
| set(CMAKE_CXX_STANDARD 17) |
| @@ -0,0 +1,13 @@ | |||
| project(huawei-fusion-charger) | |||
There was a problem hiding this comment.
Suggested change
| project(huawei-fusion-charger) | |
| cmake_minimum_required(VERSION 3.16) | |
| project(huawei-fusion-charger) |
|
|
||
| set(CMAKE_EXPORT_COMPILE_COMMANDS ON) | ||
|
|
||
| if(BUILD_TESTS) |
There was a problem hiding this comment.
Suggested change
| if(BUILD_TESTS) | |
| if(EVEREST_CORE_BUILD_TESTING) |
Comment on lines
+5
to
+7
| if(BUILD_TESTS) | ||
| include(CTest) | ||
| endif() |
Comment on lines
+12
to
+19
| if(BUILD_TESTING) | ||
| if(TEST_COVERAGE) | ||
| # Add coverage flags | ||
| target_compile_options(modbus-client PUBLIC --coverage) | ||
| target_link_options(modbus-client PUBLIC --coverage) | ||
| endif() | ||
| add_subdirectory(tests) | ||
| endif() |
There was a problem hiding this comment.
see comments about coverage and testing
| target_include_directories(modbus-registers PUBLIC include) | ||
| target_link_libraries(modbus-registers PUBLIC modbus-server) | ||
|
|
||
| if(BUILD_TESTING) |
Comment on lines
+11
to
+18
| if(BUILD_TESTING) | ||
| if(TEST_COVERAGE) | ||
| # Add coverage flags | ||
| target_compile_options(modbus-server PUBLIC --coverage) | ||
| target_link_options(modbus-server PUBLIC --coverage) | ||
| endif() | ||
| add_subdirectory(tests) | ||
| endif() |
There was a problem hiding this comment.
see comments on testing and coverage
| Build with tests: | ||
|
|
||
| ```bash | ||
| cmake -B build -DBUILD_TESTS=ON |
Comment on lines
+55
to
+73
| ## Run tests | ||
|
|
||
| Without coverage: | ||
|
|
||
| ```bash | ||
| cmake -B build -DBUILD_TESTS=ON | ||
| cd build | ||
| make -j$(nproc) | ||
| ctest | ||
| ``` | ||
|
|
||
| With coverage (note that in some cases the build folder must be removed first): | ||
| ```bash | ||
| cmake -B build -DBUILD_TESTS=ON -DTEST_COVERAGE=ON | ||
| cd build | ||
| make -j$(nproc) | ||
| ctest | ||
| make coverage | ||
| ``` |
There was a problem hiding this comment.
see comments on coverage and testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added the Huawei_V100R023C10 PowerSupply driver from BaseCamp
Issue ticket number and link
Checklist before requesting a review