-
Notifications
You must be signed in to change notification settings - Fork 663
DYN-7928 Update LiveChartsCore.SkiaSharpView.WPF version to latest #15723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7928
Looks like two binaries included are not versioned yet from the new nuget breaking out build step. Waiting for regression farm before next step. |
It seems there will be two additional assemblies from the dependency upgrade. See Bin_diff job for details. In short, these are: Warning of new assemblies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the LiveChartsCore and LiveChartsCore.SkiaSharpView.WPF package versions from 2.0.0-rc3.3 to 2.0.0-rc5.4 to keep dependencies current. Additionally, the LICENSE file has been updated to reflect these new version numbers.
- Updated package versions in the CoreNodeModelsWpf.csproj file.
- Synchronized version numbers in the LICENSE.txt file.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/Libraries/CoreNodeModelsWpf/CoreNodeModelsWpf.csproj | Updated LiveChartsCore and LiveChartsCore.SkiaSharpView.WPF versions to rc5.4. |
LICENSE.txt | Updated version numbers for LiveChartsCore-related packages to rc5.4. |
Comments suppressed due to low confidence (1)
LICENSE.txt:525
- The LICENSE file now references the updated version for LiveChartsCore.SkiaSharpView along with the others. Please verify that the inclusion of LiveChartsCore.SkiaSharpView (which is not directly referenced in the project file) is intended and consistent with dependency management.
LiveChartsCore v.2.0.0-rc5.4:
Purpose
Per https://jira.autodesk.com/browse/DYN-7928, update SkiaSharp version to keep it up-to-date. Follow up of #15503
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
N/A
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of