Skip to content

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Dec 12, 2024

Purpose

Per https://jira.autodesk.com/browse/DYN-7928, update SkiaSharp version to keep it up-to-date. Follow up of #15503

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

N/A

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added this to the 3.5 milestone Dec 12, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7928

@QilongTang QilongTang changed the title DYN-7928 Update SkiaSharp dependencies DYN-7928 Update LiveChartsCore.SkiaSharpView.WPF version to latest Dec 12, 2024
@QilongTang
Copy link
Contributor Author

Looks like two binaries included are not versioned yet from the new nuget breaking out build step. Waiting for regression farm before next step.

@QilongTang
Copy link
Contributor Author

It seems there will be two additional assemblies from the dependency upgrade. See Bin_diff job for details. In short, these are:

Warning of new assemblies.
Name: \DynamoVisualProgramming.DynamoCoreRuntime\lib\net8.0\GLWpfControl.dll, Type: Assembly, ChangeType: New
Name: \DynamoVisualProgramming.DynamoCoreRuntime\lib\net8.0\OpenTK.dll, Type: Assembly, ChangeType: New

@QilongTang QilongTang added the DNM Do not merge. For PRs. label Feb 18, 2025
@QilongTang QilongTang requested a review from Copilot June 2, 2025 15:18
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the LiveChartsCore and LiveChartsCore.SkiaSharpView.WPF package versions from 2.0.0-rc3.3 to 2.0.0-rc5.4 to keep dependencies current. Additionally, the LICENSE file has been updated to reflect these new version numbers.

  • Updated package versions in the CoreNodeModelsWpf.csproj file.
  • Synchronized version numbers in the LICENSE.txt file.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Libraries/CoreNodeModelsWpf/CoreNodeModelsWpf.csproj Updated LiveChartsCore and LiveChartsCore.SkiaSharpView.WPF versions to rc5.4.
LICENSE.txt Updated version numbers for LiveChartsCore-related packages to rc5.4.
Comments suppressed due to low confidence (1)

LICENSE.txt:525

  • The LICENSE file now references the updated version for LiveChartsCore.SkiaSharpView along with the others. Please verify that the inclusion of LiveChartsCore.SkiaSharpView (which is not directly referenced in the project file) is intended and consistent with dependency management.
LiveChartsCore v.2.0.0-rc5.4:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM Do not merge. For PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants