Skip to content

[UI] Update image resolution & UI improvements#44

Merged
Divinelink merged 4 commits into
mainfrom
feature/image-performance
May 15, 2024
Merged

[UI] Update image resolution & UI improvements#44
Divinelink merged 4 commits into
mainfrom
feature/image-performance

Conversation

@Divinelink

@Divinelink Divinelink commented May 15, 2024

Copy link
Copy Markdown
Owner

This pull request optimizes the image loading for posters on the home screen. We've switched to using lower resolution images, resulting in a significant reduction in file size (at least 15x smaller). Previously, poster images were around 500-1000KB each. With this change, the new 300x450 images are only 10-40KB. This optimization will noticeably improve loading speeds and reduce network bandwidth usage when scrolling through the home screen.

Additionally, we improved the accessibility of the bottom sheet on the main screen. To ensure users can access all content regardless of length, we've implemented scrolling functionality. Also, the "Details & More" button now remains fixed at the bottom of the sheet, guaranteeing its visibility for users with dexterity or scrolling limitations.

We've also introduced a new module called "designsystem" and moved the related compose theming there.

Fixes #43 #25

We need to update the image url so that we fetch a lower sized image. Since our cards are small enough, the resolution is kept the same while reducing the size of each image by at least 20 times.
@Divinelink Divinelink self-assigned this May 15, 2024
@codecov

codecov Bot commented May 15, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 80.45113% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 62.97%. Comparing base (d1ef1a7) to head (13c7dce).
Report is 2 commits behind head on main.

Files Patch % Lines
...erama/settings/components/SettingsRadioPrefItem.kt 0.00% 12 Missing ⚠️
...movierama/ui/components/BottomSheetMovieContent.kt 87.23% 3 Missing and 9 partials ⚠️
.../app/appearance/usecase/ObserveThemeModeUseCase.kt 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   65.06%   62.97%   -2.10%     
==========================================
  Files         161      156       -5     
  Lines        4068     3787     -281     
  Branches      667      656      -11     
==========================================
- Hits         2647     2385     -262     
+ Misses       1087     1074      -13     
+ Partials      334      328       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Divinelink Divinelink merged commit d45400f into main May 15, 2024
@Divinelink Divinelink deleted the feature/image-performance branch May 15, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate image resolution on home screen

1 participant