Skip to content

Fix list details error on unauthenticated users#284

Merged
Divinelink merged 4 commits into
mainfrom
feature/list-details-on-unauthorised-user
Apr 24, 2026
Merged

Fix list details error on unauthenticated users#284
Divinelink merged 4 commits into
mainfrom
feature/list-details-on-unauthorised-user

Conversation

@Divinelink

Copy link
Copy Markdown
Owner

Summary

Fixes an issue where the user would get "Something went wrong" if they opened a list details deeplink. The issue was the AuthTMDBClient wouldn't pass a bearer auth token, resulting in a 401 api response.

Additionally, handles the case where the Edit FAB button on a list should not be displayed if the list does not belong to the logged in user.

@Divinelink Divinelink self-assigned this Apr 24, 2026
@Divinelink Divinelink added the enhancement New feature or request label Apr 24, 2026
@Divinelink Divinelink force-pushed the feature/list-details-on-unauthorised-user branch from 0fd390a to 2e4e389 Compare April 24, 2026 17:14
@codecov

codecov Bot commented Apr 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.93%. Comparing base (432c551) to head (2e4e389).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...link/feature/lists/details/ListDetailsViewModel.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #284   +/-   ##
=======================================
  Coverage   75.92%   75.93%           
=======================================
  Files         749      749           
  Lines       21108    21113    +5     
  Branches     2343     2345    +2     
=======================================
+ Hits        16027    16032    +5     
+ Misses       4106     4105    -1     
- Partials      975      976    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Divinelink Divinelink merged commit 892eb8b into main Apr 24, 2026
4 checks passed
@Divinelink Divinelink deleted the feature/list-details-on-unauthorised-user branch April 24, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant