Capture the rustc environment and project it into run
#4421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR properly sets the environment variables that cargo sets when it
cargo runs your app.This fixes the bevy use case where they rely on CARGO_MANIFEST_DIR being set to locate the asset folder.
To capture the environment, we simply extract the env vars prefixed with
CARGO_from theRUSTCWRAPPER. Previously, we weren't wrapping cargo, so implementing this would've been super annoying, but now that we do, it was a quite easy fix.Note that dioxus itself relies on CARGO_MANIFEST_DIR not being set in some cases and I haven't tested those yet.The only case we rely on it is as a fallback when DIOXUS_CLI_ENABLED=false