-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
updated the dependencies - maintaining compatibility and tests #4363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated the dependencies - maintaining compatibility and tests #4363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wgpu
version needs to go back down. Otherwise looks reasonable to me.
@debanjanbasu 您好,#4363的依赖问题目前进展如何?大概多久能解决呢?谢谢! |
Done all the changes requested. Need approval and merge mate ☝️. |
@ealmloff - while running some tests... cargo test --lib --bins --tests --examples --workspace I'm getting this: error[E0277]: the trait bound `StandardUniform: Distribution<usize>` is not satisfied
--> packages/core/tests/fuzzing.rs:242:37
|
242 | let node = match rand::random::<usize>() % range {
| ^^^^^ the trait `Distribution<usize>` is not implemented for `StandardUniform`
|
= help: the following other types implement trait `Distribution<T>`:
`StandardUniform` implements `Distribution<()>`
`StandardUniform` implements `Distribution<(A, B)>`
`StandardUniform` implements `Distribution<(A, B, C)>`
`StandardUniform` implements `Distribution<(A, B, C, D)>`
`StandardUniform` implements `Distribution<(A, B, C, D, E)>`
`StandardUniform` implements `Distribution<(A, B, C, D, E, F)>`
`StandardUniform` implements `Distribution<(A, B, C, D, E, F, G)>`
`StandardUniform` implements `Distribution<(A, B, C, D, E, F, G, H)>`
and 31 others Any advice? I've made it u8 from usize, which should technically work, but maybe in certain cases you want to generate a really large number? Can do u128? |
It just needs to be a random number more than the mod range. |
@ealmloff / @nicoburns - found the issues with the wgpu example, and the jsframework. Fixes have been pushed 🙏. Up for review again... apologies for the trouble. |
Fixed the issues with CI, clippy tests should pass now. |
Any updates to this one ?🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were a few unused swc dependencies after the update and a dependency updated in CI. The rest of these changes look good. Thanks!
With the latest rustc nightly, I'm getting this error due to a dependency on swc_ecma_utils - v7.0.0. Did the basic upgrade, but then had to upgrade other dependencies as well. No functional, or tests have been changed.
The following error is being produced: