Skip to content

fix "multiple" attribute #4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025
Merged

fix "multiple" attribute #4323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3b9076
fix "multiple" attribute
jkelleyrtp Jun 25, 2025
f947526
change timeout in spin future
jkelleyrtp Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/cli/src/workspace.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,16 @@ impl Workspace {
});

let spin_future = async move {
tokio::time::sleep(Duration::from_millis(500)).await;
tokio::time::sleep(Duration::from_millis(1000)).await;
println!("{GLOW_STYLE}warning{GLOW_STYLE:#}: Waiting for cargo-metadata...");
tokio::time::sleep(Duration::from_millis(2000)).await;
for x in 1..=5 {
for x in 1..=100 {
tokio::time::sleep(Duration::from_millis(2000)).await;
println!(
"{GLOW_STYLE}warning{GLOW_STYLE:#}: ({x}/5) Taking a while, maybe your internet is down?"
);
println!("{GLOW_STYLE}warning{GLOW_STYLE:#}: (Try {x}) Taking a while...");

if x % 10 == 0 {
println!("{GLOW_STYLE}warning{GLOW_STYLE:#}: maybe check your network connection or build lock?");
}
}
};

Expand Down
2 changes: 1 addition & 1 deletion packages/interpreter/src/js/common.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/interpreter/src/js/core.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/interpreter/src/js/hash.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
[6449103750905854967, 17669692872757955279, 13069001215487072322, 11420464406527728232, 3770103091118609057, 5444526391971481782, 3838853708034771301, 5052021921702764563, 10988859153374944111, 18245313843715340442]
[6449103750905854967, 17669692872757955279, 13069001215487072322, 11420464406527728232, 3770103091118609057, 5444526391971481782, 3838853708034771301, 5052021921702764563, 10988859153374944111, 11339769846046015954]
9 changes: 6 additions & 3 deletions packages/interpreter/src/ts/set_attribute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,12 @@ export function setAttributeInner(
setAttributeDefault(node, field, value);
// reset the selected value whenever multiple changes
// @ts-ignore
let options = node.options;
for (const option of options) {
option.selected = option.defaultSelected;
if (node.options !== null && node.options !== undefined) {
// @ts-ignore
let options = node.options;
for (const option of options) {
option.selected = option.defaultSelected;
}
}
break;

Expand Down
Loading