Skip to content

Fix hot reloading stylesheets with an existing query parameter #3315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix hot reloading stylesheets with an existing query parameter #3315

merged 1 commit into from
Dec 9, 2024

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Dec 9, 2024

Fixes #3307

@ealmloff ealmloff added bug Something isn't working web relating to the web renderer for dioxus desktop Suggestions related to the desktop renderer hot-reload Related to the hot reload crate labels Dec 9, 2024
@jkelleyrtp jkelleyrtp merged commit b643461 into DioxusLabs:main Dec 9, 2024
17 checks passed
@ealmloff ealmloff deleted the fix-hot-reloading-assets-with-existing-query branch December 9, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkelleyrtp jkelleyrtp jkelleyrtp approved these changes

Assignees
No one assigned
Labels
bug Something isn't working desktop Suggestions related to the desktop renderer hot-reload Related to the hot reload crate web relating to the web renderer for dioxus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cache busting query string breaks URLs with an existing query string
2 participants
@ealmloff @jkelleyrtp