Skip to content

Fix base path on web and fullstack #3247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 52 commits into from
Nov 27, 2024
Merged

Fix base path on web and fullstack #3247

merged 52 commits into from
Nov 27, 2024

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Nov 21, 2024 •
edited
Loading

This PR fixes the base path in the config and fixes the title of desktop apps in release mode. Reading a CLI config how has this matrix of sources:

Platform Debug mode (assumed to be running under the CLI) Release mode
Web Read from a <meta> tag Read from env!
Non-web Read from env at runtime Read from env!

Fixes #2928
Fixes #2929
Fixes #3159
Stacked on #3195

@ealmloff
Create a crate for constant serialization of config structs for manganis
3fb6d4f
@ealmloff
use SerializeConst for the image asset builder
349acab
@ealmloff
switch to a declarative macro for assets
3fe59ed
@ealmloff
clean up asset macro a bit
4db9c9a
@ealmloff
add serializable options for each asset type
b6533d0
@ealmloff
serialize const vec
d6c23b4
@ealmloff
Add unique path formatting
a346486
@ealmloff
implement the new manganis macro
96043f1
@ealmloff
Merge branch 'main' into restore-manganis
123b429
@ealmloff
optimize assets in the CLI
5faf8d5
@ealmloff
Fix clippy
a6aebfa
@ealmloff
Fix assets with dioxus formattable
2c2c941
@ealmloff
reduce fuzzing test limits
f0e57c2
@ealmloff
use the new syntax in examples
32460a4
@ealmloff
fix formatting
7d92da5
@ealmloff
Final doc and test pass on const-serialize
3904749
@ealmloff
fix avif support
cc40767
@ealmloff
Fix manganis doc tests
2d43173
@ealmloff
cache asset optimization
000d143
@ealmloff
Split out asset and bundled asset
fa304a3
@ealmloff
Merge branch 'main' into restore-manganis
713954d
@ealmloff
make hash pointer width independent
0a8726f
@ealmloff
remove const serialize cargo lock
bb3ad52
@ealmloff
Fix manganis macro docs
0502863
@ealmloff
all tests passing
df38d3d
@ealmloff
add constvec::is_empty method to fix clippy lint
712e9e3
@ealmloff
remove nasm feature
59438c6
@ealmloff
simplify test_rsplit_once test so typos passes
8b22f6b
@ealmloff
fix range syntax for stable
50d0d41
@ealmloff
revert example change from clippy fix
06985f7
@ealmloff ealmloff added bug Something isn't working cli Related to the dioxus-cli program router Related to the router implementation labels Nov 21, 2024
@ealmloff ealmloff marked this pull request as ready for review November 23, 2024 04:00
@jkelleyrtp jkelleyrtp merged commit 3d62fbf into DioxusLabs:main Nov 27, 2024
17 checks passed
@ealmloff ealmloff deleted the fix-base-path-again branch November 27, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working cli Related to the dioxus-cli program router Related to the router implementation
Projects
None yet
Milestone
No milestone
2 participants
@ealmloff @jkelleyrtp