feat: traverse the target directory instead of intercepting the linker to collect assets #3228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested against android/ios/web 👍 Builds are so much faster now. Would like to add caching of the rlib parsing but it's already sooo fast. In the future maybe we can do it in parallel and/or cache the .rlib parsing since it's likely that only the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it came to me in a dream...
instead of intercepting the linker, simply traverse the
depsandincrementaldirectories for their artifacts.This drastically speeds up asset bundling times and is much nicer when used with LTO since we are basically forced to compile twice with LTO.
This is also generally better for folks who run
cargo checkwith our profiles wrt cache thrashing.Fixes: #3148