FTX Exchange Implemented #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParseOrder method in the ExchangeKrakenAPI class will now parse the fee from the response and set it in the order result.
Added a exchange property to the ticker model to be able to identify what exchange it came from.
Added the base implementation for the FTX exchange.
Implemented onGetMarketSynbolsAsync method for FTX exchange
Implemented OnGetMarketSymbolsMetadataAsync for FTX exchange Modified ,methods to exclude to futures symbols
Added method for creating the appropriate signature on the request so that it can authenticate against the private API for the FTX exchange Implemented the OnGetAmountsAsync method for the FTX exchange.
Implemented ongetHistoricaltrades for the FTX exchange.
Modified onGetHistoricalTrade to use utility method for parsing.
Moved methods into alphabetical order
Implemented websocket connection for retrieving ticker information.
Refined websocket ticker implementation to make use of utility functions for parsing.
* checks for future coins
Implemented onPlaceOrderAsync for FTX exchange.
Added remaining overrides of methods required to be implemented to FTX exchange Added implementation of OnCancelOrderAsync Added implementation of OnGetCandleAsync
Implemented getOrderBook for FTX exchange.
Implemented GetCompletedOrders method for FTX exchange
Implemented GetTickersAsync method for FTX
Fixed minor issues in some of the methods Modified order of methods so they are alphabetical Removed debug test class.
Added FTX to supported exchanges
Modified OnGetOrderDetailsAsync for ftx exchange to include isClientOrderId parameter
Removed unused Models folder
This reverts commit 161bbba.
vslee
requested changes
Sep 27, 2021
| @@ -22,6 +22,12 @@ | |||
| <RepositoryType>git</RepositoryType> | |||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <Compile Remove="API\Exchanges\FTX\Models\**" /> | |||
There was a problem hiding this comment.
Is there a reason you're specifying these in the csproj?
There was a problem hiding this comment.
Nope, think I accidentally added it while removing an unused folder I added.
| /// <summary> | ||
| /// The name of the exchange the tick was sent from. | ||
| /// </summary> | ||
| public string Exchange { get; set; } |
There was a problem hiding this comment.
If you'd like to add this property, can you go through all of the other exchanges and set it? (you can do it quickly by using "find references" in Visual Studio.)
There was a problem hiding this comment.
Done. I thought I had actually done this by adding the logic on a utility method for parsing the ticker, but hadn't realised not all exchanges make use of it.
vslee
reviewed
Sep 28, 2021
| // "size": 31431.0, | ||
| // "reduceOnly": false, | ||
| // "ioc": false, | ||
| // "postOnly": false, |
There was a problem hiding this comment.
Looks like this exchange supports postOnly. Can you add that?
vslee
reviewed
Sep 28, 2021
| { | ||
| // https://docs.ftx.com/#get-order-status | ||
|
|
||
| JToken result = await MakeJsonRequestAsync<JToken>($"/orders/{orderId}", null, await GetNoncePayloadAsync()); |
There was a problem hiding this comment.
Can you also handle the case where isClientOrderId is true?
Modified exchange tickers to include the name of the exchange it came from for all exchange implementations. Added PostOnly parameter to place order method for FTX implementation. Modified GetOrderDetails for FTX implementation so that it handles retrieval via client order ids. Removed unnecessary exclusion in project file
Fixed issue with reference to the exchange name in Gemini when creating a ticker instance.
|
Believe that should be all the requested modifications completed. |
vslee
approved these changes
Sep 28, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the FTX exchange now implemented as per #634.