Skip to content

CI/CD: change addChangeLog to false #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Conversation

vslee
Copy link
Collaborator

@vslee vslee commented Nov 18, 2019

@vslee vslee added the maintenance such as tests label Nov 18, 2019
Copy link
Collaborator

@johnnyasantoss johnnyasantoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we'll have to wait for the next month upgrade. :)
Is there any way to automate the release drafter to create a tag every month if there were any changes to the code base?

@johnnyasantoss
Copy link
Collaborator

I guess we'll have to wait for the next month upgrade. :)
Is there any way to automate the release drafter to create a tag every month if there were any changes to the code base?

I believe it is possible to combine Github actions on: schedule with the pipeline that builds a new version every month. There's a section on the readme of the project to explain it further. https://github.com/toolmantim/release-drafter#github-actions

@vslee
Copy link
Collaborator Author

vslee commented Nov 19, 2019

Currently, the release-drafter is a GH app rather than a GH action. The doc you referenced just refers to how often the release-drafter updates the draft. I think we should keep the release-drafter as is since it is nice to have the notes updated every pull.
We can create a separate GH action or Azure pipeline step to push a new tag every month.

@vslee vslee merged commit 7b15124 into DigitalRuby:master Nov 19, 2019
@vslee
Copy link
Collaborator Author

vslee commented Nov 19, 2019

Actually, once release-drafter/release-drafter#141 is resolved, we can have release-drafter tag and publish the releases. A PR resolving is linked from that issue and looks like it's almost to be merged.

@vslee vslee changed the title change to addChangeLog to false CI/CD: change addChangeLog to false Nov 21, 2019
@vslee vslee added the CI/CD label Nov 21, 2019
szmcdull pushed a commit to szmcdull/ExchangeSharp that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants