Skip to content

HitBTC: allow OnGetDepositHistoryAsync() for all currencies #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2019
Merged

HitBTC: allow OnGetDepositHistoryAsync() for all currencies #489

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8c38b0
HitBTC: allow OnGetDepositHistoryAsync() for all currencies
vslee Nov 13, 2019
ee525fd
Update ExchangeHitbtcAPI.cs
jjxtra Nov 13, 2019
4973684
Update ExchangeHitbtcAPI.cs
jjxtra Nov 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ExchangeSharp/API/Exchanges/Hitbtc/ExchangeHitbtcAPI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*
/*
MIT LICENSE

Copyright 2017 Digital Ruby, LLC - http://www.digitalruby.com
Expand Down Expand Up @@ -384,7 +384,7 @@ protected override async Task<ExchangeDepositDetails> OnGetDepositAddressAsync(s
/// </summary>
/// <param name="currency"></param>
/// <returns></returns>
protected override async Task<IEnumerable<ExchangeTransaction>> OnGetDepositHistoryAsync(string currency)
protected override async Task<IEnumerable<ExchangeTransaction>> OnGetDepositHistoryAsync(string? currency)
{
List<ExchangeTransaction> transactions = new List<ExchangeTransaction>();
// [ {"id": "6a2fb54d-7466-490c-b3a6-95d8c882f7f7","index": 20400458,"currency": "ETH","amount": "38.616700000000000000000000","fee": "0.000880000000000000000000", "address": "0xfaEF4bE10dDF50B68c220c9ab19381e20B8EEB2B", "hash": "eece4c17994798939cea9f6a72ee12faa55a7ce44860cfb95c7ed71c89522fe8","status": "pending","type": "payout", "createdAt": "2017-05-18T18:05:36.957Z", "updatedAt": "2017-05-18T19:21:05.370Z" }, ... ]
Expand All @@ -393,7 +393,7 @@ protected override async Task<IEnumerable<ExchangeTransaction>> OnGetDepositHist
{
foreach (JToken token in result)
{
if (token["currency"].ToStringInvariant().Equals(currency))
if (string.IsNullOrWhiteSpace(currency) || token["currency"].ToStringInvariant().Equals(currency))
{
ExchangeTransaction transaction = new ExchangeTransaction
{
Expand Down