Binance.US: added exchange support #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vslee
commented
Nov 10, 2019
vslee
commented
- since Binance and Binance.US share the same API, they inherit from BinanceGroupCommon
- this is similar to the refactoring in OKGroup OKCoin: added exchange support #418
- fixed bug in ExchangeGlobalCurrencyReplacements in BitBank
- added trade stream (websockets) support for Binance DEX
- unfortunately, Binance DEX doesn't share the same API as Binance and Binance.US
- now that a new ExchangeBinanceDEXAPI class is created, others are free to contribute additional implementation details
- since Binance and Binance.US share the same API, they inherit from BinanceGroupCommon - this is similar to the refactoring in OKGroup DigitalRuby#418 - fixed bug in ExchangeGlobalCurrencyReplacements in BitBank - added trade stream (websockets) support for Binance DEX - unfortunately, Binance DEX doesn't share the same API as Binance and Binance.US - now that a new ExchangeBinanceDEXAPI class is created, others are free to contribute additional implementation details
|
Thanks so much for sharing this code. Any change we can make the Binance specific models internal? |
jjxtra
previously approved these changes
Nov 10, 2019
jjxtra
approved these changes
Nov 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.