C# 8 phase 1 #472
C# 8 phase 1 #472
Conversation
vslee
commented
Oct 25, 2019
vslee
commented
- jjxtra began by marking some objects using the nullable (?) reference type signifier
| { | ||
| throw new InvalidOperationException("Invalid salt"); | ||
| } | ||
| var cs = new CryptoStream(encrypted, AES.CreateDecryptor(), CryptoStreamMode.Read); |
There was a problem hiding this comment.
Maybe here would be good to use using var expression.
There was a problem hiding this comment.
Can you add an example of what you mean? Then I can add a commit to this PR. Alternatively, I can merge this PR and you can put it into your current PR or a new one.
There was a problem hiding this comment.
I was referring to the same expression in the second example of this post.
Also, I can add it later :)
|
Need @jjxtra to put an approving review before I can merge (I know it's strange for him to be reviewing his own code but since I was the one starting the PR, I can't review my own PR) |
|
I don't know if I approve of my code to be honest :) We might consider backing out of nullable reference types on a project level and going to a per file level to reduce the warning barrage. |
- we can go back to project wide once we convert everything
|
Far fewer warnings now (~50 instead of ~500) |
|
I think we can merge now, and then whittle the rest of the warnings down with time. |
|
progress towards #450 |
