-
-
Notifications
You must be signed in to change notification settings - Fork 375
BL3P: added Orderbook implementation and tests (websockets) #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This implementation can be tested with the command |
You can update the readme to show the new websockets feature |
Add Orderbook via WebSockets Made OnGetMarketSymbolsMetadataAsync protected internal to be able to mock in tests Add unit tests and timestamp Rename folder and namespace
Rebased and updated the readme 😃 |
Somewhat off topic, but do you have sway with BL3P? I was looking at their websockets API and noticed that the trade stream doesn't include a trade ID (or order ID). Is that something you could have them add? Would be helpful in figuring out if there are missing/duplicate trades. |
I'd still like the bl3p exchange specific model objects to be marked as internal instead of public, anyone have any strong objections? In my ideal world they would simply be child objects inside the partial exchange class, that way we keep the namespace clean, but I am less picky about that. |
I can change it to private nested classes like the NDAX |
@jjxtra |
I work at Bitonic (the company behind BL3P) and I can check with our team about those additional IDs :) |
Regarding the PR #474 I would like to point out that using this strategy of using partial classes we are creating yet another indentation level and at the same time making the classes a new type of name space, which is bad for the type itself, because it gets polluted with symbols that could be hidden by access modifier. |
Add Orderbook via WebSockets
Made OnGetMarketSymbolsMetadataAsync protected internal to be able to mock in tests
Add unit tests and timestamp
Rename folder and namespace