Skip to content

New terminal interface implementation #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 23, 2019
Merged

New terminal interface implementation #467

merged 9 commits into from
Oct 23, 2019

Conversation

johnnyasantoss
Copy link
Collaborator

@johnnyasantoss johnnyasantoss commented Oct 21, 2019

I tried to keep all existing sub commands with the same functionality. The key difference in this implementation is the argument parser and the use of OOP to design the commands.

Try it out and please give me some feedback if you find any bugs. Keep it in mind that I didn't fix errors in previous existing commands

fixes #464

Copy link
Collaborator

@vslee vslee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really use the command line ConsoleApp, but seems like a nice cleanup.

@vslee vslee requested a review from jjxtra October 22, 2019 05:01
@jjxtra
Copy link
Collaborator

jjxtra commented Oct 23, 2019

Thanks so much for sharing your changes!

@jjxtra jjxtra merged commit 7b6e897 into DigitalRuby:master Oct 23, 2019
@johnnyasantoss
Copy link
Collaborator Author

I'll add more commands to it but the base is now there 😊

@johnnyasantoss johnnyasantoss deleted the console branch October 23, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider to make the console app more friendly and standard
3 participants