workaround SignalR HubConnection.Stop() bug #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vslee
commented
Oct 2, 2019
vslee
commented
- bug in SignalR where Stop() throws a NRE if it times out
- .NET client API: HubConnection.Stop() while connecting throws exception SignalR/SignalR#3561
- also handle case where trying to dispose of a HubConnection where the Transport is null
- bug in SignalR where Stop() throws a NRE if it times out - SignalR/SignalR#3561 - also handle case where trying to dispose of a HubConnection where the Transport is null
jjxtra
approved these changes
Oct 2, 2019
vslee
added a commit
that referenced
this pull request
Oct 2, 2019
- bug in SignalR where Stop() throws a NRE if it times out - SignalR/SignalR#3561 - also handle case where trying to dispose of a HubConnection where the Transport is null (cherry picked from commit 31be2f6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.