Merge WebSocketAsync into master #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The console example and web socket methods were not using task properly. This is the start of work to fix that.
Connection re-connect will be initiated, the errors should not crash out of the method and should only log info messages
vslee
reviewed
Sep 12, 2019
Ensure Async naming convention for anything return a Task
vslee
reviewed
Sep 12, 2019
vslee
reviewed
Sep 12, 2019
vslee
approved these changes
Sep 12, 2019
|
Not sure if you're planning any more changes, but looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anyone have any objections about merging this? The web socket API has changed slightly and now uses Task to be consistent with the other APIs. I've also tweaked the Bittrex web socket code slightly to not throw uncaught exceptions in cases where the exceptions are not an issue.