-
-
Notifications
You must be signed in to change notification settings - Fork 196
Open
Description
Caught by a test.
An archive can exist here:
Line 186 in d79dd8f
| my $cnt = 0; |
But not here:
Line 196 in d79dd8f
| eval { $id = compute_id($file); }; |
triggering a die.
More generally, there's no guarantee of file existence made to compute_id (cnt loop only sleeps at most 5s, which can lead file to be deleted elsewhere). We should probably demote the error logs to warning here, or lock the resource and ensure shinobu can read the file without a delete API interfering.
Metadata
Metadata
Assignees
Labels
No labels