Fixup the complainy docs line #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't ideal. The build and tests are split because the full Can't we make the test job mandatory? (Looking at the ruleset jobs like |
|
Ah ha! That makes sense. The test jobs are already "mandatory" ... but "skipped" satisfies the "mandatory" requirement :|. I'll make the "build" step mandatory, too, which would have caught the failure. |
grahamc
force-pushed
the
push-suswmmmyvmxm
branch
from
6be354c to
37ab15a
Compare
grahamc
changed the title
edolstra
approved these changes
Jun 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #109 it merged after all the builds failed. This is because the
testjobs were skipped, because their dependentbuildjob failed. Thetestjob being skipped was considered a pass, so it failed and merged right away.I made the
buildchecks mandatory as well in the settings.