fix: Updated Korean translations#786
Merged
DenverCoder1 merged 1 commit intoDenverCoder1:mainfrom Mar 13, 2025
Merged
Conversation
DenverCoder1
approved these changes
Mar 13, 2025
Owner
DenverCoder1
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the update!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I made some big changes for this translation. Here's an explanation:
"Longest Streek"and"Longest Week Streak"Previously used
"최대"which literally means"biggest". I changed it to"최장"which means"longest". Also, added"연속"as the translation of"streak"."Week Streak"Previously translated as
"주간 기여 수"which only indicates the weekly contribution amount. I changed it to"주간 연속 기여수". The addition of"연속"as a translation of"streak"."Excluding {days}"Previously translated as
"{days} 제외된", which means "excluded {days}" (passive form), it is not precise in conveying the meaning of exclusion. I changed it to"{days} 제외하고".If this needs to be discussed again, please feel free.
Type of change
How Has This Been Tested?
composer testChecklist:
Screenshots
None