Refactor call state to its own module.#30
Open
aebrahim wants to merge 1 commit into
Open
Conversation
aebrahim
force-pushed
the
refactor_state
branch
from
500aaf8 to
ff9b9ad
Compare
aebrahim
force-pushed
the
refactor_state
branch
4 times, most recently
from
e6b0d14 to
4ca2545
Compare
aebrahim
force-pushed
the
refactor_state
branch
from
4ca2545 to
c714b6c
Compare
GhaithqD
reviewed
Mar 24, 2026
| call_state = self._state_factory() | ||
| with call_state.lock: | ||
| if not call_state.called: | ||
| call_state.return_value = _iterator_wrappers.GeneratorWrapper( |
There was a problem hiding this comment.
_iterator_wrappers.GeneratorWrapper takes an allow_reset parameter which we used to pass originally before the refactoring, now allow_reset is not passed and is mainly used in _wrap, doesn't this mean if we pass any *args the first arg might be bound to allow_reset?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.