Test exception handling preserves the call stack.#17
Open
aebrahim wants to merge 1 commit into
Open
Conversation
aebrahim
changed the title
aebrahim
force-pushed
the
preserve_stack
branch
3 times, most recently
from
dfba7db to
701383f
Compare
aebrahim
changed the title
This way, using a once decorator will not swallow all exception traces.
aebrahim
force-pushed
the
preserve_stack
branch
from
701383f to
0c79890
Compare
mattalbr
reviewed
Jan 9, 2024
mattalbr
left a comment
mattalbr
left a comment
Collaborator
There was a problem hiding this comment.
Looks like no code changes were needed, this just adds test coverage?
| container.exception = exception | ||
| traceback_exception = traceback.TracebackException.from_exception(exception) | ||
| if not len(traceback_exception.stack): | ||
| test.fail("Exception stack not preserved. Did you use the raw assertRaises by mistake?") |
Collaborator
There was a problem hiding this comment.
If there was a raw assertRaises, wouldn't we never get to this failure in the first place?
| locations = [(frame.filename, frame.lineno) for frame in traceback_exception.stack] | ||
| line_number = line.line | ||
| error_message = [ | ||
| f"Traceback for exception {repr(exception)} did not have frame on line {line_number}. Exception below\n" |
Collaborator
There was a problem hiding this comment.
This line is a bit strange, can you explain what it's about?
Member
Author
Yup, exactly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, using a once decorator will not swallow all exception traces.