Skip to content

Poisson, Gaussian, Complex Gaussian with tests #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: mg/noises/background
Choose a base branch
from

Conversation

Pwhsky
Copy link
Collaborator

@Pwhsky Pwhsky commented Aug 20, 2025

Builds on mg/noises/background to implement torch testing with the backend test class.

@Pwhsky Pwhsky requested a review from mirjagranfors August 21, 2025 14:10
Copy link
Collaborator

@mirjagranfors mirjagranfors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have written some comments on the Gaussian noise class. Some of the comments also apply to the other classes. Once you have had a chance to address them, I can go through the remaining classes in more detail. Let me know if anything is unclear.

Offset = Background


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we usually have two empty lines between different classes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants