feat(dipu): set pin_memory to false for unsupported vendor #898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lljbash
changed the title
lljbash
approved these changes
Jul 16, 2024
fandaoyi
approved these changes
Jul 16, 2024
Wrench-Git
pushed a commit
to DeepLink-org/deeplink.framework.dev
that referenced
this pull request
Jul 16, 2024
…org#898) * pin_memory set false for unsupported vendor * python black
Wrench-Git
pushed a commit
to DeepLink-org/deeplink.framework.dev
that referenced
this pull request
Jul 16, 2024
…org#898) * pin_memory set false for unsupported vendor * python black
Wrench-Git
pushed a commit
to DeepLink-org/deeplink.framework.dev
that referenced
this pull request
Jul 16, 2024
…org#898) * pin_memory set false for unsupported vendor * python black
zhangzefeng92
pushed a commit
to DeepLink-org/deeplink.framework.dev
that referenced
this pull request
Jul 18, 2024
* feat: remove sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S2等没有实现pin_memory的vendor，需要在框架层对pin_memory设置为False，是不方便的。
因此在DIPU层对vendor进行判断，强行设置pin_memory为False，并打印相关LOG。