perf(dipu): faster aten::mul in cuda & muxi #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrench-Git
force-pushed
the
faster_mul
branch
2 times, most recently
from
a51cfbb to
ad2e7e0
Compare
fandaoyi
reviewed
Jul 12, 2024
fandaoyi
reviewed
Jul 15, 2024
fandaoyi
approved these changes
Jul 15, 2024
lljbash
approved these changes
Jul 16, 2024
lljbash
changed the title
Wrench-Git
added a commit
to DeepLink-org/deeplink.framework.dev
that referenced
this pull request
Jul 16, 2024
* faster aten::mul in cuda * improve the code format * loose the check for scalar tensor * improve the code * let the logic of mul diff on different devices. * Update autogen_diopi_wrapper.py * Update diopi_functions.yaml * Update OpUtils.hpp
Wrench-Git
added a commit
to DeepLink-org/deeplink.framework.dev
that referenced
this pull request
Jul 16, 2024
* faster aten::mul in cuda * improve the code format * loose the check for scalar tensor * improve the code * let the logic of mul diff on different devices. * Update autogen_diopi_wrapper.py * Update diopi_functions.yaml * Update OpUtils.hpp
Wrench-Git
added a commit
to DeepLink-org/deeplink.framework.dev
that referenced
this pull request
Jul 16, 2024
* faster aten::mul in cuda * improve the code format * loose the check for scalar tensor * improve the code * let the logic of mul diff on different devices. * Update autogen_diopi_wrapper.py * Update diopi_functions.yaml * Update OpUtils.hpp
zhangzefeng92
pushed a commit
to DeepLink-org/deeplink.framework.dev
that referenced
this pull request
Jul 18, 2024
update ../../impl/ascend/device_configs.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change remove a redundency transformation mul_tensor->mul_scalar->mul_tensor. Also with a faster BinaryOpInferrer.
The aten::mul is almost as fast as torch in cpu avg.