Fix , in long TXT data #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We likely can't change the behavior there for everything? Have you done some research in the relevant specs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use amphp/dns which rely on libdns and i discovered that all my DKIM TXT queries wasn't valid.
I found some "," in all response.
For exemple with google dkim: TXT of 20230601._domainkey.gmail.com
libdns give me: (import part is 4T4HZb2,PY2bQtE)
and nslookup -type=txt 20230601._domainkey.gmail.com: (important part is 4T4HZb2" "PY2bQtE)
libdns obviously implode both data field with a , which give a wrong answer.
So this small PR fixe the issue but i don't know if it's brakes something else or a proper fix for master branch.