Adding .NET Support for Target Branch Testing #5024
Merged
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link04
added a commit
to DataDog/dd-trace-dotnet
that referenced
this pull request
Aug 12, 2025
## Summary of changes Adding new stage to check if a label has been added to the PR for Azure to decide wether a Docker image should be created based on the PR or not(currently we only do it for master after each merge). - Related system test PR where I tested the image being used correctly(a 4 lines change): DataDog/system-tests#5024 - Location where the image gets used and all tests pass: https://github.com/DataDog/system-tests/actions/runs/16763951714/job/47465265591?pr=5024#step:7:72 ## Reason for change For us to be able to review/merge system-test PRs with higher confidence and remove the need to run locally for cases where the user may not want/need to. ## Implementation details Updated the action, workflow and pipeline files needed to take into account the label and use the branch name instead. ## Test coverage This is the test, the first commits add the docker image and tag it as expected: [Location](https://github.com/DataDog/dd-trace-dotnet/pkgs/container/dd-trace-dotnet%2Fdd-trace-dotnet) The last commit makes sure the image gets deleted when this PR(with its label) closes, so the above should not have it anymore: [Location](https://github.com/DataDog/dd-trace-dotnet/pkgs/container/dd-trace-dotnet%2Fdd-trace-dotnet) There could still be a scenario where the label gets removed and then the PR closed where the image could still remain but I doubt any of us would that...
link04
changed the title
link04
force-pushed
the
maximo/target-branch-for-dotnet
branch
from
7823d6e to
24f1475
Compare
link04
force-pushed
the
maximo/target-branch-for-dotnet
branch
from
7b19c40 to
f6d9645
Compare
link04
changed the title
zacharycmontoya
approved these changes
Aug 12, 2025
Co-authored-by: Lucas Pimentel <[email protected]>
link04
changed the title
robertomonteromiguel
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
.NET was not able to run PR specific changes against system test so I am just trying to make it possible.
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present