[K9VULN-6211] Add context to logs #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChouraquiBen
force-pushed
the
benjamin.chouraqui/add-context-to-logs
branch
2 times, most recently
from
e3fe057 to
405a4cd
Compare
Refs: K9VULN-6211
Refs: K9VULN-6211
Refs: K9VULN-6211
Also decided to make te output prettier Corrected a log to make it have an actual level Refs: K9VULN-6211
also added missing parameter to some test Refs: K9VULN-7714
ChouraquiBen
force-pushed
the
benjamin.chouraqui/add-context-to-logs
branch
from
af016c8 to
abe41ed
Compare
|
Logs on the Explorer with the added context. |
|
Logs on KICS locally (when the consolePrint flag is passed as true in the args) |
Refs: K9VULN-6211
chouze
approved these changes
Aug 22, 2025
pkg/printer/printer.go
Outdated
| for index := range summary.Queries { | ||
| idx := len(summary.Queries) - index - 1 | ||
| if summary.Queries[idx].Severity == model.SeverityTrace { | ||
| continue | ||
| } | ||
|
|
||
| fmt.Printf( | ||
| (&logger).Info().Msgf( |
There was a problem hiding this comment.
unless I'm missing something, I don't think you need to grab a pointer to use the logger
pkg/printer/printer.go
Outdated
| @@ -167,13 +169,13 @@ func PrintResult(summary *model.Summary, printer *Printer, usingCustomQueries bo | |||
| return nil | |||
| } | |||
|
|
|||
| func printSeverityCounter(severity string, counter int, printColor color.RGBColor) { | |||
| fmt.Printf("%s: %d\n", printColor.Sprint(severity), counter) | |||
| func printSeverityCounter(severity string, counter int, logger *zerolog.Logger) { | |||
There was a problem hiding this comment.
generally it's fine to just grab the logger again, instead of passing it along
Refs: K9VULN-6211
Refs: K9VULN-6211
This way, we will use the same logger Refs: K9VULN-6211
refs: K9VULN-6211
…eters Refs: K9VULN-6211
ChouraquiBen
force-pushed
the
benjamin.chouraqui/add-context-to-logs
branch
from
056878d to
2e3d1d7
Compare
…lure Refs: K9VULN-6211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Proposed Changes
Proposed Changes
Currently, the logs have only the message attached to them for the developers to gather informations on what is happening.
The change here is to add some "context" to those logs. This means that attached to the logs, there will be not only the message but also the repository, the branch and the commit sha, also the org and the org_id.
Here are some logs with the new infos on them: https://dd.datad0g.com/logs/livetail?query=service%3Aiac-scanning&refresh_mode=paused&storage=driveline&from_ts=1756208553000&to_ts=1756209453000&live=false
I submit this contribution under the Apache-2.0 license.