Skip to content

Add ThreadFilterBenchmark #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

zhengyu123
Copy link

@zhengyu123 zhengyu123 commented Jun 17, 2025

What does this PR do?:
This benchmark is extracted from @r1viollet 's PR#209

Motivation:
I would like to merge this benchmark separately, so we can use it to experiment various ideas for improving thread filter.

Additional Notes:

How to test the change?:

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.
  • JIRA: PROF-11548

Unsure? Have a question? Request a review!

Copy link

🔧 Report generated by pr-comment-cppcheck

CppCheck Report

Errors (2)

Warnings (4)

Style Violations (295)

Copy link

🔧 Report generated by pr-comment-scanbuild

Copy link
Collaborator

@jbachorik jbachorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's start with this.
My only objection is that this is, technically, not a microbenchmark. The measured code does a lot of things so it will be highly susceptible to noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants