Revert "Migrate MySQL to new schema collector" #22103
Conversation
This reverts commit 569fb2a.
eric-weaver
added
backport/7.74.x
and removed
documentation
integration/mysql
team/agent-integrations
team/database-monitoring-agent
labels
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| mock.patch('datadog_checks.mysql.databases_data.DatabasesData._get_tables', return_value=[1, 2]), | ||
| ): | ||
| with pytest.raises(StopIteration): | ||
| databases_data._fetch_database_data("dummy_cursor", time.time(), "my_db") |
There was a problem hiding this comment.
When time.time is patched to return a huge elapsed duration, _fetch_database_data immediately calls send_truncated_msg, which indexes self._data_submitter.db_info[db_name]. In this test no call to store_db_infos populates that mapping, so the call raises a KeyError before the StopIteration the test asserts, causing the new unit test to fail deterministically. Seed the db metadata (e.g., via store_db_infos([{"name": "my_db"}])) or adjust the assertion to match the actual exception.
Useful? React with 👍 / 👎.
temporal-github-worker-1
bot
dismissed
sethsamuel’s stale review
Review from sethsamuel is dismissed. Related teams and files:
- database-monitoring
- mysql/CHANGELOG.md
- database-monitoring-agent
- mysql/changelog.d/22103.fixed
datadog-agent-integrations-bot
bot
added
documentation
integration/mysql
qa/skip-qa
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
eric-weaver
deleted the
revert-21729-seth.samuel/DBMON-5801-move-my-sql-to-new-schema-collector
branch
This reverts commit 8b4e2b7.
* Revert "Migrate MySQL to new schema collector (#21729)" This reverts commit 569fb2a. * Add changelog (cherry picked from commit 8b4e2b7) Co-authored-by: Eric Weaver <[email protected]>
Reverts #21729
We need to revert this schem collection refactor. These optimized schema collection queries break schema collection on many older Mysql / MariaDB versions due to introduction of newer functions. Pulling this out of 7.74 release in order to gracefully support falling back to this existing collection method on unsupportable versions in a future agent release