Skip to content

Fix type of otel.system.memory.usage #20915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 13, 2025
Merged

Fix type of otel.system.memory.usage #20915

merged 6 commits into from
Aug 13, 2025

Conversation

angristan
Copy link
Member

The type of this OTel metric is equivalent to a gauge, not a count, cf: https://opentelemetry.io/docs/specs/semconv/system/system-metrics/#metric-systemmemoryusage

@angristan angristan requested review from a team as code owners August 1, 2025 08:43
@angristan angristan requested a review from IbraheemA August 1, 2025 08:43
@angristan
Copy link
Member Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 4, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-08-04 08:29:20 UTC ℹ️ Start processing command /merge

2025-08-04 08:29:25 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-08-04 12:30:08 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@angristan angristan removed the request for review from IbraheemA August 5, 2025 08:19
@github-actions GitHub Actions
Copy link

⚠️ Recommendation: Add qa/skip-qa Label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

@angristan angristan added the qa/skip-qa Automatically skip this PR for the next QA label Aug 13, 2025
@angristan
Copy link
Member Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 13, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-08-13 14:21:47 UTC ℹ️ Start processing command /merge

2025-08-13 14:22:09 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-08-13 14:57:53 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@angristan
Copy link
Member Author

/remove

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 13, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-08-13 14:57:37 UTC ℹ️ Start processing command /remove

2025-08-13 14:57:50 UTC ℹ️ Devflow: /remove

@angristan
Copy link
Member Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 13, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-08-13 15:04:34 UTC ℹ️ Start processing command /merge

2025-08-13 15:04:56 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-08-13 18:00:27 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@sarah-witt sarah-witt added this pull request to the merge queue Aug 13, 2025
Merged via the queue into master with commit 5a21c3a Aug 13, 2025
40 checks passed
@sarah-witt sarah-witt deleted the slange/fix-otel-type branch August 13, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AAraKKe AAraKKe AAraKKe approved these changes

@sarah-witt sarah-witt sarah-witt approved these changes

@fpddog fpddog fpddog approved these changes

@jade-guiton-dd jade-guiton-dd jade-guiton-dd approved these changes

Assignees
No one assigned
Labels
agent/approved ecosystems/review-requested integration/otel mergequeue-status: done product/review-requested qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations team/opentelemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@angristan @AAraKKe @sarah-witt @fpddog @jade-guiton-dd