-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[DBMON-5545] Update core tags with agent host name #20870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DBMON-5545] Update core tags with agent host name #20870
Conversation
@@ -1005,7 +1005,10 @@ def _send_database_instance_metadata(self): | |||
"collection_interval": self._config.database_instance_collection_interval, | |||
'dbms_version': payload_pg_version(self.version), | |||
'integration_version': __version__, | |||
"tags": [t for t in self._non_internal_tags if not t.startswith('db:')], | |||
"tags": [t for t in self._non_internal_tags if not t.startswith('db:')] + [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this tags
field is for custom tags and not for internal tags.
Adding agent_hostname as the core tags to be able to inject it into the instance summary view, every query sample & into normalized queries
Review from sethsamuel is dismissed. Related teams and files:
- database-monitoring-agent
- mysql/tests/test_metadata.py
- mysql/tests/test_mysql.py
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
What does this PR do?
We want to add tags around agent hostname to be the tags.
Adding
agent_hostname
as the core tags to be able to inject it into the instance summary view, every query sample & into normalized queriesTesting:

Instance summary page:
Query Samples:

Normalized query:

Motivation
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged