Skip to content

[DBMON-5545] Update core tags with agent host name #20870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

sangeetashivaji
Copy link

@sangeetashivaji sangeetashivaji commented Jul 28, 2025

What does this PR do?

We want to add tags around agent hostname to be the tags.
Adding agent_hostname as the core tags to be able to inject it into the instance summary view, every query sample & into normalized queries

Testing:
Instance summary page:
image

Query Samples:
image

Normalized query:
image

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@@ -1005,7 +1005,10 @@ def _send_database_instance_metadata(self):
"collection_interval": self._config.database_instance_collection_interval,
'dbms_version': payload_pg_version(self.version),
'integration_version': __version__,
"tags": [t for t in self._non_internal_tags if not t.startswith('db:')],
"tags": [t for t in self._non_internal_tags if not t.startswith('db:')] + [
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this tags field is for custom tags and not for internal tags.
Adding agent_hostname as the core tags to be able to inject it into the instance summary view, every query sample & into normalized queries

@sangeetashivaji sangeetashivaji marked this pull request as ready for review August 4, 2025 21:04
@sangeetashivaji sangeetashivaji changed the title [DBMON-5545] Update tags with agent version and host name [DBMON-5545] Update core tags with agent host name Aug 4, 2025
sethsamuel
sethsamuel previously approved these changes Aug 6, 2025
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed sethsamuel’s stale review August 6, 2025 19:16

Review from sethsamuel is dismissed. Related teams and files:

  • database-monitoring-agent
    • mysql/tests/test_metadata.py
    • mysql/tests/test_mysql.py
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.50%. Comparing base (571da3a) to head (dbd93e2).
⚠️ Report is 69 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sangeetashivaji sangeetashivaji marked this pull request as draft August 6, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants