Don't check external psycopg packages for openssl3 copies #20513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alopezz
force-pushed
the
alopez/allow-openssl3-from-psycopg
branch
3 times, most recently
from
b91f7dc to
5f63dc7
Compare
alopezz
force-pushed
the
alopez/allow-openssl3-from-psycopg
branch
from
31eb34b to
b42b18a
Compare
alopezz
force-pushed
the
alopez/allow-openssl3-from-psycopg
branch
from
b42b18a to
e1639a9
Compare
This reverts commit 75b9ade.
rdesgroppes
previously approved these changes
Jun 17, 2025
| ): | ||
| """Check if a wheel contains any unacceptable files and exit if found.""" | ||
| if any(wheel.name.startswith(pkg_prefix) for pkg_prefix in bypass_prefixes): | ||
| return |
There was a problem hiding this comment.
Since (I guess) we aim at removing the tolerance, I would add some verbosity about it (warning or so). What do you think?
There was a problem hiding this comment.
Sounds fair, I'll add that.
temporal-github-worker-1
bot
dismissed
rdesgroppes’s stale review
Review from rdesgroppes is dismissed. Related teams and files:
- agent-build
- .builders/scripts/repair_wheels.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds a mechanism to bypass the "don't include externally built openssl3" checks.
Motivation
This will let us update from psycopg2 to psycopg(3) without having to build it ourselves (at the expense of shipping different openssl3 versions). psycopg2 got off the hook so far because it ships openssl 1, not 3.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged