Use modern namespace packaging #19826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (51.56%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
sethsamuel
approved these changes
Mar 13, 2025
temporal-github-worker-1
bot
dismissed
iliakur’s stale review
Review from iliakur is dismissed.
Related teams and files:
- agent-integrations
- datadog_checks_dev/datadog_checks/dev/tooling/templates/integration/check/{check_name}/datadog_checks/init.py
- datadog_checks_dev/datadog_checks/dev/tooling/templates/integration/check_only/{check_name}/datadog_checks/init.py
- datadog_checks_dev/datadog_checks/dev/tooling/templates/integration/jmx/{check_name}/datadog_checks/init.py
- datadog_checks_dev/datadog_checks/dev/tooling/templates/integration/logs/{check_name}/datadog_checks/init.py
temporal-github-worker-1
bot
added
agent/review-requested
and removed
agent/approved
labels
Kyle-Neale
approved these changes
Mar 13, 2025
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
nubtron
pushed a commit
that referenced
this pull request
May 26, 2025
* Use modern namespace packaging * update templates
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now that we've dropped Python 2 we can use the modern approach: https://packaging.python.org/en/latest/guides/packaging-namespace-packages/#native-namespace-packages
Notes
I kept the
__init__.pyfile fordatadog_checks_basepackage because a very old version of our integrations had imports right underdatadog_checksand they live there so we must support that, for now...