Skip to content

cockroachdb: remove obsolete compactor metrics #18446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbowens
Copy link

@jbowens jbowens commented Aug 28, 2024

What does this PR do?

Removes metadata and reference to CockroachDB timeseries metrics that have not been exported by CockroachDB versions in many years (~v21.1).

Motivation

The documentation of these metrics is likely to confuse users.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

The 'compactor queue' has not been around since at least v21.1.
Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbowens 👋 thanks for the contribution!

Removing metrics from metadata.csv is something we try to avoid. That file shows up in the Datadog UI for all versions of the integration. The thing we tend to do is mark metrics as Deprecated if we stop submitting them in some version of the integration.

As for the metrics themselves, would it be possible to include some conditional that skips them if we detect a certain version of cockroachdb? With the current changeset the next release of our integration essentially drops support for certain older versions of cockroach and we're not sure that's a good idea just yet.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.28%. Comparing base (d385405) to head (bd7b958).
Report is 56 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
cockroachdb 93.19% <ø> (ø)
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants