fix new appsec go setup links #30877
Conversation
Signed-off-by: Eliott Bouhana <[email protected]>
📝 Documentation Team Review RequiredThis pull request requires approval from the @DataDog/documentation team before it can be merged. Please ensure your changes follow our documentation guidelines and wait for a team member to review and approve your changes. |
|
@eliottness hey, this looks good but I have a couple questions about this file https://docs-staging.datadoghq.com/eliottness/fix-new-go-setup-2/security/application_security/setup/go/dockerfile/:
Thanks |
Signed-off-by: Eliott Bouhana <[email protected]>
| code_lang: gateway-api | ||
| type: multi-code-lang | ||
| code_lang_weight: 50 |
There was a problem hiding this comment.
This was rendering badly and this is experimental so removing it from the top bar is okay
There was a problem hiding this comment.
there's a different issue:
if you go to https://docs-staging.datadoghq.com/eliottness/fix-new-go-setup-2/security/application_security/setup/go/ and click any of the Environments, their titles are all "Enabling App and API Protection for Go" instead of distinguishing which environment, like "Enabling App and API Protection for Go in AWS ECS".
So, if you click Kubernetes, you get ?tab=kubernetes in the URL but the doc title is just "Enabling App and API Protection for Go". No mention of Kubernetes.
This is also an issue for search results, because they display the titles.
What does this PR do? What is the motivation?
This PR is fixing formatting issue and missing links
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes